fix(inflight): reduce shrinking limit #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inflights are initialized per partition, so limit of 1000000 makes no sense
dkropachev
added
enhancement
vponomaryov
reviewed
May 10, 2023
| @@ -21,7 +21,7 @@ import ( | |||
| // We track inflights in the map, maps in golang are not shrinking | |||
| // Therefore we track how many inflights were deleted and when it reaches the limit | |||
| // we forcefully recreate the map to shrink it | |||
| const shrinkInflightsLimit = 1000000 | |||
| const shrinkInflightsLimit = 1000 | |||
There was a problem hiding this comment.
Why 1000?
Do we know the cost of map recreation?
There was a problem hiding this comment.
Just guesstimate.
This is limit of deletions to trigger recreation, recreation it self depends on the number of items in the map, which is limited only by number partition size, which is Uint64.Max/partitionCount usually it is 18446744073709551615/10000 = 1844674407370955.
With current implementation this limit is pretty much reachable, which is source of memory consumption.
But after #309 and #307 are fixed we should not see more than pkBufferReuseSize + concurrency, which is usually 100+10 infligths per partition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #298
Inflights are initialized per partition, so limit of
1000000makes no sense